Skip to content

Add discovery_info check to LCN light platform#20280

Merged
rohankapoorcom merged 2 commits intohome-assistant:devfrom
alengwenus:dev_lcn_discovery_info
Jan 20, 2019
Merged

Add discovery_info check to LCN light platform#20280
rohankapoorcom merged 2 commits intohome-assistant:devfrom
alengwenus:dev_lcn_discovery_info

Conversation

@alengwenus
Copy link
Copy Markdown
Contributor

Description:

Added a guard clause to the LCN light plarform to catch the case where discovery_info is None.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@homeassistant homeassistant added platform: light.lcn small-pr PRs with less than 30 lines. labels Jan 20, 2019
@ghost ghost added the in progress label Jan 20, 2019
"""Set up the LCN light platform."""
if discovery_info is None:
return

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Added discovery_info check to LCN light platform Add discovery_info check to LCN light platform Jan 20, 2019
@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@rohankapoorcom rohankapoorcom merged commit d5dcb8f into home-assistant:dev Jan 20, 2019
@ghost ghost removed the in progress label Jan 20, 2019
alengwenus added a commit to alengwenus/home-assistant-core that referenced this pull request Jan 21, 2019
@alengwenus alengwenus deleted the dev_lcn_discovery_info branch January 21, 2019 15:38
@balloob balloob mentioned this pull request Feb 6, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
* Added discovery_info check to LCN light platform

* Removed whitespaces
kellerza pushed a commit to kellerza/ha-core that referenced this pull request Feb 24, 2019
* Added discovery_info check to LCN light platform

* Removed whitespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed integration: lcn small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants